Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #10

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Improve test coverage #10

merged 2 commits into from
Jan 17, 2019

Conversation

petroav
Copy link
Contributor

@petroav petroav commented Jan 16, 2019 •
edited
Loading

  • add libp2p badges to README
  • expand reader writer tests

@petroav
Copy link
Contributor Author

petroav commented Jan 16, 2019

Travis failure seems unrelated to changes

$ make deps
go get github.com/whyrusleeping/gx
# github.com/multiformats/go-multiaddr
../../multiformats/go-multiaddr/codec.go:140:10: undefined: strings.Builder
../../multiformats/go-multiaddr/component.go:69:8: undefined: strings.Builder
../../multiformats/go-multiaddr/component.go:76:32: undefined: strings.Builder
make: *** [gx] Error 2
The command "make deps" failed and exited with 2 during .

@ghost ghost assigned Stebalien Jan 16, 2019
@ghost ghost added the status/in-progress In progress label Jan 16, 2019
@Stebalien Stebalien merged commit f8aaa1f into libp2p:master Jan 17, 2019
@Stebalien
Copy link
Member

Thanks!

@ghost ghost removed the status/in-progress In progress label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petroav @Stebalien