feat: switch to go-netroute #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on libp2p/go-netroute#4. |
willscott
reviewed
Mar 30, 2020
There was a problem hiding this comment.
https://github.com/libp2p/go-netroute/releases/tag/v0.1.1 should fix bsd build
| return nil, err | ||
| } | ||
|
|
||
| _, ip, _, err := router.Route(net.IPv4zero) |
There was a problem hiding this comment.
this is v4 centric. may want to try on both v4 and v6
There was a problem hiding this comment.
We currently only support V4 anyways because that's what our port mapping protocols support. When we fix #16, we'll need to use IPv6.
This library makes the correct syscalls instead of shelling out to a binary.
Stebalien
force-pushed
the
feat/netroute
branch
from
b5848cc
to
d4146fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library makes the correct syscalls instead of shelling out to a binary.