Skip to content
This repository has been archived by the owner on Jan 7, 2023. It is now read-only.

Fix tests #16

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Fix tests #16

merged 2 commits into from
Aug 27, 2021

Conversation

Stebalien
Copy link
Member

  1. Avoid marshaling ed25519 to PEM, it doesn't work.
  2. Ignore close errors when the underlying connection was already closed.

@Stebalien
test: don't try to marshal ed25519 to PEM
f5ecaf4
@Stebalien
test: handle closing quirks
d2721d9 
Closing may need to write, which will cause it to fail if the other side
has already closed. The correct fix is to use shutdown to half-close,
then wait for the other side, but that's honestly not worth it right
now. So I just fixed the tests to pass.
@marten-seemann marten-seemann mentioned this pull request Aug 27, 2021
Merged
@Stebalien Stebalien merged commit cfeec8e into master Aug 27, 2021
@Stebalien Stebalien deleted the fix/tests branch August 27, 2021 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @marten-seemann