This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
remove connection setup #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muxtest/muxt.go
Outdated
| tests := []TransportTest{ | ||
| SubtestConstructSwarm, | ||
| SubtestSimpleWrite, | ||
| SubtestSimpleWrite100msgs, | ||
| SubtestStress1Swarm1Conn1Stream1Msg, | ||
| SubtestStress1Swarm1Conn1Stream100Msg, | ||
| SubtestStress1Swarm1Conn100Stream100Msg, | ||
| SubtestStress1Swarm10Conn50Stream50Msg, | ||
| // SubtestStress1Swarm10Conn50Stream50Msg, |
There was a problem hiding this comment.
is this disabled for some reason?
muxtest/muxt.go
Outdated
| func SubtestAll(t *testing.T, tr smux.Transport) { | ||
|
|
||
| func SubtestAll(t *testing.T, lo listenerOpts, streamMuxer smux.Transport) { | ||
| f, err := os.Create("./log.txt") |
marten-seemann
force-pushed
the
master
branch
3 times, most recently
from
3b4ba73
to
806e0d1
Compare
Connection setup will be handled in go-libp2p-conn. go-peerstream now handles iconn.Conn and the associated streams
Serve was recently removed from the interface.
|
Superseded by the refactor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the connection setup to go-libp2p-conn, see libp2p/go-libp2p-conn#9.
It should be merged once we activate multi-stream support, as added in libp2p/go-libp2p-transport#20.