Rename errors #14
Merged
Rename errors #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
commented
Feb 28, 2020
| @@ -5,69 +5,69 @@ import ( | |||
| "fmt" | |||
| ) | |||
|
|
|||
| type YamuxError struct { | |||
| type Error struct { | |||
There was a problem hiding this comment.
Previously was started with repository suffix.
| // if the backlog is exceeded, or if there was a remote GoAway. | ||
| ErrConnectionReset = &YamuxError{msg: "stream reset"} | ||
| ErrStreamReset = &Error{msg: "stream reset"} |
There was a problem hiding this comment.
Not a connection reset, but a stream one.
Stebalien
approved these changes
Feb 28, 2020
Stebalien
added
the
status/blocked
|
@Stebalien, what about merging this first and then pointing |
Stebalien
removed
the
status/blocked
|
Done and released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of libp2p/go-libp2p#814