Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't keepalive when the connection is busy #16

Merged
merged 3 commits into from
Mar 13, 2020
Merged

fix: don't keepalive when the connection is busy #16

merged 3 commits into from
Mar 13, 2020

Commits on Mar 13, 2020

  1. chore: avoid leaking ping timers 

    We wouldn't permanently leak them, but we'd leak them for the write timeout (10s).
    @Stebalien
    Stebalien committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    888369a View commit details
    Browse the repository at this point in the history

  2. fix: don't keepalive when the connection is busy 

    * It's a waste of bandwidth.
* It causes us to think the connection is dead because the other side is too
busy sending us _other_ data to respond to the ping.

fixes #15
    @Stebalien
    Stebalien committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    bddc294 View commit details
    Browse the repository at this point in the history

  3. ci: configure travis

    @Stebalien
    Stebalien committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    922d36f View commit details
    Browse the repository at this point in the history