Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

feat: timeline and close checking #55

Merged
merged 4 commits into from
Sep 19, 2019
Merged

feat: timeline and close checking #55

merged 4 commits into from
Sep 19, 2019

Conversation

jacobheun
Copy link
Contributor

  • Adds checking and docs for timeline (open and close)
  • Adds checking and docs for close on the MultiaddrConnection
  • Adds checking and docs for filter. It's been around, but hasn't been documented or tested
  • Removes reference of the go implementation. This repo was originally intended to be used as an interface for both, but it's JS specific, let's treat it that way.

While this shouldn't technically be a breaking change for the latest minor version, it will very likely break tests, so we will do a minor version bump.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun merged commit 993ca1c into master Sep 19, 2019
@jacobheun jacobheun deleted the feat/timeline branch September 19, 2019 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants