This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: add buffer, cleanup, reduce size #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add buffer related to ipfs/js-ipfs#2924 - remove unnecessary eslint ignore - remove tweelnacl and use node-forge - remove browserify-aes and use node-forge - use multibase to encode b58 - require only sha256 from multihashing - reduce bundle size after all the deps here ipfs/js-ipfs#2924 are merged libp2p-crypto will be able to be bundle with `node: false` 🎉
56 tasks
|
@hugomrdias have you done any downstream testing of this with libp2p or ipfs?
Do you have any numbers on the reduction? Looks like we should add bundlesize to CI. |
|
ah yes will update bundle size in aegir.js 155KB -> 122.65KB Would nice to merge this already with libp2p/js-libp2p-crypto-secp256k1#25 these numbers include this PR.
not yet but i will im following the path :) i will report here my findings also you can track here ipfs/js-ipfs#2924 everything in there should work together in order. |
|
also dont bother fixing the bundle size github check i will do it later. |
jacobheun
reviewed
Mar 17, 2020
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after all the deps here ipfs/js-ipfs#2924 are merged, libp2p-crypto will be able to be bundle with
node: false🎉