chore: update dht #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables DHT by default. The tests won't pass here until libp2p is released, which needs this module to be released in order for it's tests to pass. BREAKING CHANGE: The DHT is now enabled by default
achingbrain
force-pushed
the
chore/update-dht
branch
from
b4d665f
to
4ab25f1
Compare
1 task
3 tasks
|
Something is using the DHT incorrectly causing CI to fail. Can you look at it? |
|
Yes, libp2p is 😢 - there's a circular dependency - the fix is in libp2p/js-libp2p#1009 which needs this PR merged & released before it'll pass since it uses it in it's interop tests. |
|
I'm going to merge and release this since it's stuck - the tests won't pass until there's a libp2p release, and there won't be a libp2p release without this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables DHT by default. The tests won't pass here until libp2p is released, which needs this module to be released in order for it's tests to pass.
Depends on:
BREAKING CHANGE: The DHT is now enabled by default