chore: update to new multiformats #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on: - [ ] multiformats/js-multiformats#91 BREAKING CHANGE: uses the CID class from the new multiformats module
20 tasks
src/index.js
Outdated
| @@ -116,14 +115,14 @@ class DelegatedPeerRouting { | |||
| // Track the addresses, so we can yield them when done | |||
| result.responses.forEach(response => { | |||
| peers.set(response.id, { | |||
| id: PeerId.createFromCID(response.id), | |||
| id: PeerId.createFromB58String(response.id), | |||
There was a problem hiding this comment.
Do we want to make this change? I remember we wanted to move towards not using b58 peer IDs and this will mean changing this back again
There was a problem hiding this comment.
PeerId.createFromCID(response.id) here was accidentally taking a base58 encoded string so can't be used any more. Annoyingly the DHT result type 2 has reponse.id as a CID instance whereas type 1 has it as a string.
I've changed it to use PeerId.parse so we can add support for extra bases there without having to refactor everything in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
BREAKING CHANGE: uses the CID class from the new multiformats module