This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
WIP fix: messages don't go out of order #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested if there is a specific amount of messages when this gets triggered? |
|
I tested in js-ipfs that 10 is always fine, 100 and 1000 is mostly fine (but you can see it breaking) 10k always breaks at some point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still haven't had the time to work properly in this fix, but essentially what needs to happen is that we need a way to signal the sender that the previous message was actually sent.
Currently something is wrong, initially suspicion was that API was not properly sync, but now I wonder if it is a problem with the time-cache that goes wrong with 10K messages in Node.js 4 (very specific)
Tests needs to be added (same test that is in js-ipfs).