This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat!: pubsub Message types for signature policies #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
reviewed
Jun 29, 2022
| key?: Uint8Array | ||
| } | ||
|
|
||
| export interface StrictNoSignMessage { | ||
| topic: string |
There was a problem hiding this comment.
No from field in unsigned messages?
There was a problem hiding this comment.
Yeah, see the comment on StrictNoSign. looks like the text was taken from here: https://github.com/libp2p/specs/tree/master/pubsub#signature-policy-options
|
Could just be |
|
Do these things need a We've needed that in other places, eg: if (msg.type === 'signed') {
// now safe to access `msg.sequenceNumber`, `msg.signature` etc without casting
} |
achingbrain
reviewed
Jun 29, 2022
wemeetagain
force-pushed
the
feat/pubsub-message-type
branch
from
3d0cd77
to
7df06b0
Compare
BREAKING CHANGE: The `Message` type is now either a `StrictSignMessage` or a `StrictNoSignMessage`
wemeetagain
force-pushed
the
feat/pubsub-message-type
branch
from
7df06b0
to
0437bfa
Compare
achingbrain
approved these changes
Jul 31, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2022
## [@libp2p/interface-pubsub-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-pubsub-v1.0.4...@libp2p/interface-pubsub-v2.0.0) (2022-07-31) ### ⚠ BREAKING CHANGES * The `Message` type is now either a `SignedMessage` or a `UnsignedMessage` * the inbound/outbound stream types have changed ### Features * pubsub Message types for signature policies ([#266](#266)) ([9eb710b](9eb710b)) ### Bug Fixes * make stream types Uint8ArrayLists ([#272](#272)) ([ace7e0c](ace7e0c)) ### Trivial Changes * update project config ([#271](#271)) ([59c0bf5](59c0bf5))
|
🎉 This PR is included in version @libp2p/interface-pubsub-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2022
## [@libp2p/interface-pubsub-compliance-tests-v2.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-pubsub-compliance-tests-v1.0.4...@libp2p/interface-pubsub-compliance-tests-v2.0.0) (2022-07-31) ### ⚠ BREAKING CHANGES * The `Message` type is now either a `SignedMessage` or a `UnsignedMessage` ### Features * pubsub Message types for signature policies ([#266](#266)) ([9eb710b](9eb710b)) ### Trivial Changes * update project config ([#271](#271)) ([59c0bf5](59c0bf5)) * update sibling dependencies [skip ci] ([fbd5281](fbd5281))
|
🎉 This PR is included in version @libp2p/interface-pubsub-compliance-tests-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
Messagetype is now either aStrictSignMessageor a
StrictNoSignMessage