Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

fix: Added Registrar, Dialer and Connection Manager to Libp2p object #339

Closed

Conversation

maschad
Copy link
Member

@maschad maschad commented Jan 25, 2023

Closes #338

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional to reduce the size of the libp2p api and to encourage people to use the high level methods on the libp2p node instead of reaching into the low-level components (e.g. use libp2p.dial instead of libp2p.connectionManager.openConnection etc).

@maschad
Copy link
Member Author

maschad commented Jan 29, 2023

This is intentional to reduce the size of the libp2p api and to encourage people to use the high level methods on the libp2p node instead of reaching into the low-level components (e.g. use libp2p.dial instead of libp2p.connectionManager.openConnection etc).

I understand the intention to reduce the size of the libp2p api but given that the ConnectionManager and Registrar are core to the library it would seem that those interfaces should be extended.

The impetus for this PR arose out of instances like this where more often that not a Libp2p instance would require being initiated with a ConnectionManager and Registrar (in this case for Gossipsub).

Are there multiple instances where a consumer would not want to utilize the default connection manager?
(This relates to the broader suggestion posed here)

@p-shahi
Copy link
Member

p-shahi commented Jan 31, 2023

Closing per discussion in triage meeting for reasons mentioned here: #339 (review)

Looking into alternative options where one can optionally pass in their own connection manager module

@p-shahi p-shahi closed this Jan 31, 2023
@maschad maschad deleted the fix/add-connection-manager-registrar branch January 31, 2023 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Registrar and ConnectionManager missing from interface-libp2p
3 participants