This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat: Update Connection Manager and Dialler Interfaces and Configs. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
reviewed
Feb 14, 2023
|
In order to merge this as a feature and not a breaking change a PR needs to be opened against libp2p that adds the new methods to the default connection manager. This change then needs to ship before this PR can be merged. |
Co-authored-by: Alex Potsides <alex@achingbrain.net>
maschad
requested review from
achingbrain
and removed request for
wemeetagain and
mpetrunic
|
Since libp2p/js-libp2p#1586 has been merged this can be reviewed now @achingbrain |
maschad
changed the title
|
In light of the work being done on libp2p/js-libp2p#1581 I have made some more updates that will be required for libp2p/js-libp2p#1594 |
maschad
changed the title
achingbrain
reviewed
Mar 9, 2023
|
This is no longer necessary since the refactor of the connection manager in libp2p/js-libp2p#1678 in tandem with the changes being added in libp2p/js-libp2p#1563 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid creating wrapper functions to extract a map of the connections from a default
ConnectionManagerimplementation (as mentioned in libp2p/js-libp2p#1567) , we should allow that field to be made accessible.Now whilst the
getConnectionsfunction could achieve this, it adds additional runtime logic which coulda affect performance.