fix: random walk should not be started by kad-dht

libp2p · Sep 24, 2018 · 45dfb33 · 45dfb33
1 parent c69c1a3
commit 45dfb33
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -115,14 +115,7 @@ class KadDHT {
    */
   start (callback) {
     this._running = true
-    this.network.start((err) => {
-      if (err) {
-        return callback(err)
-      }
-      this.randomWalk.start()
-
-      callback()
-    })
+    this.network.start(callback)
   }
 
   /**
@@ -134,7 +127,7 @@ class KadDHT {
    */
   stop (callback) {
     this._running = false
-    this.randomWalk.stop(() => {
+    this.randomWalk.stop(() => { // guarantee that random walk is stopped if it was started
       this.providers.stop()
       this.network.stop(callback)
     })