Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

chore: rename peer-store properties #184

Merged
merged 1 commit into from
Apr 27, 2020
Merged

chore: rename peer-store properties #184

merged 1 commit into from
Apr 27, 2020

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Apr 24, 2020 •
edited
Loading

Per libp2p/js-libp2p#610 review, we are renaming MultiaddrInfo into Address, and peerStore.get return value from PeerData into peer with an addresses property instead of multiaddrInfos.

This needs:

@vasco-santos vasco-santos mentioned this pull request Apr 24, 2020
Merged
1 task
jacobheun
jacobheun approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos vasco-santos merged commit 1f02658 into master Apr 27, 2020
@jacobheun jacobheun deleted the chore/rename-peer-store-properties branch July 10, 2020 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun