This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: add types and update all deps #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
suggested changes
Feb 5, 2021
There was a problem hiding this comment.
Thanks for taking this @achingbrain! 🎉 Also a lot of bugs caught
Left mostly small recommendations, as well as comments for future thoughts.
| multiaddrs: (peerData.addresses || []).map((address) => address.multiaddr) | ||
| provs | ||
| .forEach(id => { | ||
| const peerData = dht.peerStore.get(id) |
There was a problem hiding this comment.
Suggested change
| const peerData = dht.peerStore.get(id) | |
| const peer = dht.peerStore.get(id) |
We initially were going with the peerData naming for peerStore records, but we decided after the DHT refactor to just call peer and make it consistent here later on.
| .forEach(id => { | ||
| const peerData = dht.peerStore.get(id) | ||
|
|
||
| if (peerData) { |
There was a problem hiding this comment.
Suggested change
| if (peerData) { | |
| if (peer) { |
|
|
||
| if (peerData) { | ||
| out.push({ | ||
| id: peerData.id, |
There was a problem hiding this comment.
Suggested change
| id: peerData.id, | |
| id: peer.id, |
| if (peerData) { | ||
| out.push({ | ||
| id: peerData.id, | ||
| multiaddrs: peerData.addresses |
There was a problem hiding this comment.
Suggested change
| multiaddrs: peerData.addresses | |
| multiaddrs: peer.addresses |
| if (!peerData) { | ||
| throw errcode(new Error('No peer data found in peer store'), 'ERR_NOT_FOUND') | ||
| } | ||
|
|
||
| return { | ||
| id: peerData.id, |
There was a problem hiding this comment.
Suggested change
| id: peerData.id, | |
| id: peer.id, |
There was a problem hiding this comment.
There are other occurrences in this file, I will not flag all of them
| if (!peerData) { | ||
| throw errcode(new Error('No peer data found in peer store'), 'ERR_NOT_FOUND') | ||
| } | ||
|
|
||
| return { | ||
| id: peerData.id, | ||
| multiaddrs: peerData.addresses.map((address) => address.multiaddr) |
There was a problem hiding this comment.
Suggested change
| multiaddrs: peerData.addresses.map((address) => address.multiaddr) | |
| multiaddrs: peer.addresses.map((address) => address.multiaddr) |
achingbrain
commented
Feb 5, 2021
achingbrain
commented
Feb 5, 2021
achingbrain
commented
Feb 5, 2021
Adds types to source code, tests can be done later. Updates all deps.
achingbrain
force-pushed
the
feat/add-types
branch
from
2ce1bf4
to
2de1694
Compare
vasco-santos
suggested changes
Feb 8, 2021
| * @param {Uint8Array} key | ||
| * @param {Object} [options] | ||
| * @param {boolean} [options.shallow] shallow query (default: false) | ||
| * @returns {AsyncIterable<{ id: PeerId, multiaddrs: Multiaddr[] }>} |
There was a problem hiding this comment.
@achingbrain can we have this back?
Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types to source code, tests can be done later.
Updates all deps.
Depends on: