This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: use symbols to return routers #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DHT interface is similar to the content/peer routing interfaces but different. In order to detect content/peer routers and peer discovery implementations in [arbitrary libp2p modules](libp2p/js-libp2p#1563) use the exported symbols to create getters for them. The DHTContentRouting and DHTPeerRouting classes have been ported over from libp2p.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
## [9.1.0](v9.0.0...v9.1.0) (2023-04-27) ### Features * use symbols to return routers ([#464](#464)) ([d681aaf](d681aaf))
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
maschad
reviewed
Apr 28, 2023
| import type { Datastore } from 'interface-datastore' | ||
| import { PeerRouting, peerRouting } from '@libp2p/interface-peer-routing' | ||
| import { PeerDiscovery, peerDiscovery } from '@libp2p/interface-peer-discovery' |
There was a problem hiding this comment.
Shouldn't this be imported as @libp2p/peer-discovery based on the interface @achingbrain ?
There was a problem hiding this comment.
Ah, no - that’s a typo in the comment. Got to get that TS comment verification stuff in!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DHT interface is similar to the content/peer routing interfaces but different.
In order to detect content/peer routers and peer discovery implementations in arbitrary libp2p modules use the exported symbols to create getters for them.
The DHTContentRouting and DHTPeerRouting classes have been ported over from libp2p.