This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
Stop running queries on shutdown #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
reviewed
Apr 3, 2019
There was a problem hiding this comment.
The QueryManager should probably have a start method that gets called when the dht starts. While the use case may be low, it should be possible to start, stop and start the dht. Currently if that happen queries will fail to happen.
libp2p currently supports start/stop/start behavior. Sleeping/waking would be a potential case for this.
|
Good catch 👍 |
jacobheun
approved these changes
Apr 3, 2019
|
Makes sense - I added test cases for
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that any running queries are stopped when the DHT stops