-
Notifications
You must be signed in to change notification settings - Fork 8
feat: adds support for ed25199 and secp256k1 #31
Conversation
07ffeb2
to
9f04a54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @AlbertoElias
Can you rebase this PR with master? We are not using Jenkins CI anymore (travis now), and we need to have it here.
@vasco-santos done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for rebasing the PR @AlbertoElias
LGTM so far.
I would recommend installing the libp2p-crypto-secp256k1: AlbertoElias/js-libp2p-crypto-secp256k1#patch-1
, so that you have the id
, as well and you are able to add the remaining tests: exportKey
and importKey
.
b3e323e
to
42886f8
Compare
@vasco-santos That should be done now. I also updated exporting and importing to fix marshaling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @AlbertoElias ! Thanks
Except for a minor request that I added now, this is good to go, once libp2p-crypto-secp256k1
is released.
42886f8
to
80ee0c3
Compare
@vasco-santos Everything is fixed, but it seems that what needs updating is libp2p/js-libp2p-crypto#137 I've tampered my package-lock.json to get everything running, but if |
80ee0c3
to
cf90937
Compare
This reverts commit 9eb11f4.
I'm creating a project using js libp2p and I created a Keystore where I store secp25k1 keys using PEM encrypted PKCS #8. (so now password wouldn't be just for RSA keys). Tests include being able to use OpenSSL to verify the encrypted keys. |
Fixes #30
This is blocked by: libp2p/js-libp2p-crypto-secp256k1#13
@vasco-santos Could you review?