Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

chore: update deps #40

Merged
merged 1 commit into from
Dec 18, 2019
Merged

chore: update deps #40

merged 1 commit into from
Dec 18, 2019

Conversation

alanshaw
Copy link
Member

No description provided.

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@vasco-santos vasco-santos merged commit b6d5313 into master Dec 18, 2019
@vasco-santos vasco-santos deleted the chore/update-deps-20191217 branch December 18, 2019 10:04
@achingbrain
Copy link
Member

This has pulled in peer-id@0.13.x which breaks js-ipfs with this sort of error:

Uncaught TypeError: callback is not a function
      at /foo/js-ipfs/node_modules/libp2p-crypto/src/keys/rsa-class.js:124:7
      at /foo/js-ipfs/node_modules/libp2p-crypto/node_modules/multihashing-async/src/index.js:33:5
      at processTicksAndRejections (internal/process/task_queues.js:80:21)

This is because js-ipfs depends on peer-id@0.12.x which is has to until js-libp2p upgrades otherwise you can't dial anyone.

@achingbrain
Copy link
Member

I should say, it breaks because this went out as a patch release. Could it (or at least the peer-id upgrade) be reverted, a new patch release done and then this re-merged and released as a minor?

@jacobheun
Copy link
Contributor

libp2p-crypto is the issue, that's a breaking change, as well as the interface-datastore. peer-id is a dev dependency.

@vasco-santos can we do a revert patch release and then a minor release with this change?

@vasco-santos
Copy link
Member

oh, on it

vasco-santos added a commit that referenced this pull request Dec 18, 2019
vasco-santos pushed a commit that referenced this pull request Dec 18, 2019
@vasco-santos
Copy link
Member

Released 0.6.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants