fix: Clear interval when stopping (#63)

libp2p · Jan 4, 2018 · 1d586c3 · 1d586c3
1 parent bd993dc
commit 1d586c3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -16,6 +16,7 @@ class MulticastDNS extends EventEmitter {
     this.serviceTag = options.serviceTag || '_ipfs-discovery._udp'
     this.port = options.port || 5353
     this.peerInfo = peerInfo
+    this._queryInterval = null
   }
 
   start (callback) {
@@ -24,7 +25,7 @@ class MulticastDNS extends EventEmitter {
 
     this.mdns = mdns
 
-    query.queryLAN(this.mdns, this.serviceTag, this.interval)
+    this._queryInterval = query.queryLAN(this.mdns, this.serviceTag, this.interval)
 
     mdns.on('response', (event) => {
       query.gotResponse(event, this.peerInfo, this.serviceTag, (err, foundPeer) => {
@@ -47,6 +48,8 @@ class MulticastDNS extends EventEmitter {
     if (!this.mdns) {
       callback(new Error('MulticastDNS service had not started yet'))
     } else {
+      clearInterval(this._queryInterval)
+      this._queryInterval = null
       this.mdns.destroy(callback)
       this.mdns = undefined
     }

diff --git a/src/query.js b/src/query.js
@@ -12,7 +12,7 @@ const tcp = new TCP()
 module.exports = {
 
   queryLAN: function (mdns, serviceTag, interval) {
-    setInterval(() => {
+    return setInterval(() => {
       mdns.query({
         questions: [{
           name: serviceTag,