This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: update deps #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 tasks
|
Tests are failing because of mismatches on multiaddr versions with dependencies still using older multiaddr. Once them get released, this should be working |
vasco-santos
commented
Apr 12, 2021
| @@ -22,10 +26,17 @@ describe('compliance tests', () => { | |||
| compat: true | |||
| }) | |||
|
|
|||
| // Trigger discovery | |||
There was a problem hiding this comment.
The interface update requires discovery to be triggered to fulfil some tests, like we do in other discovery modules like: https://github.com/libp2p/js-libp2p-webrtc-star/blob/master/test/compliance.spec.js#L54
This is not the optimal solution though, and I would like to change the testing interface in the future to return multiple discovery modules instances and start them all when needed.
achingbrain
approved these changes
Apr 12, 2021
Co-authored-by: Alex Potsides <alex@achingbrain.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update deps and add github ci