This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: do not treat stream source as pushable #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
force-pushed
the
chore/reorganize-stream-source-2
branch
from
f59073a
to
dd7f318
Compare
8 tasks
achingbrain
approved these changes
Sep 8, 2022
achingbrain
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2022
## [5.2.1](v5.2.0...v5.2.1) (2022-09-08) ### Bug Fixes * do not treat stream source as pushable ([#211](#211)) ([359c103](359c103))
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #192
Since the
sourceandsinkproperties may be changed by downstream code (eg: in libp2p after multiselect completes), the muxer shouldn't rely on the initialsourceimplementation staying the same.Instead, any functionality needed by the muxer is exposed as an additional function attached to the stream.
And any functionality needed by the stream internally is used by referencing a private variable whose reference cannot change.