Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix!: upgrade to interface-stream-muxer 2.0.0 #186

Merged
merged 5 commits into from
Jun 28, 2022
Merged

fix!: upgrade to interface-stream-muxer 2.0.0 #186

merged 5 commits into from
Jun 28, 2022

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Jun 22, 2022

Adds the close() function to the StreamMuxer interface.

Fixes #185

@paralin
fix: upgrade to interface-stream-muxer 2.0.0
8b5a007 
Adds the close() function to the StreamMuxer interface.

Fixes libp2p#185

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin paralin mentioned this pull request Jun 22, 2022
Closed
paralin added a commit to aperturerobotics/starpc that referenced this pull request Jun 22, 2022
@paralin
[WIP] refactor: upgrade to interface-stream-muxer 2.0.0
072f01e 
Requires: libp2p/js-libp2p-mplex#186

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin paralin mentioned this pull request Jun 22, 2022
Closed
@wemeetagain
Copy link
Member

Can you update the interface-stream-muxer-compliance-tests too? should indicate a few more things need to be tweaked.

@wemeetagain
Copy link
Member

I think we'll need to add something like the changes to the mock muxer here: https://github.com/libp2p/js-libp2p-interfaces/pull/254/files

Specifically the adding the closeController, using it to abort the sink, checking the whether its closed or not in newStream, and deduplicating logic from source.onEnd

@paralin
Copy link
Contributor Author

paralin commented Jun 22, 2022

@wemeetagain I can take a look at it, but it's a bit out of scope of my understanding (and probably of this PR)

@wemeetagain
Copy link
Member

you got this 💪

happy to help if you get stuck

@paralin
feat: implement the abort controller logic for mplex
8dcb893 
Add the abort controller to the source.

Reference: https://github.com/libp2p/js-libp2p-interfaces/pull/254/files

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin
Copy link
Contributor Author

paralin commented Jun 22, 2022

@wemeetagain Okay, done.

@wemeetagain
Copy link
Member

@paralin looks good
@achingbrain It looks like the stream muxer compliance tests didn't get released after libp2p/js-libp2p-interfaces#254

@achingbrain
Copy link
Member

the stream muxer compliance tests didn't get released

Groan. I think it's because semantic-release-monorepo doesn't update sibling deps during a release so if a major bump occurs siblings end up depending on the old version even though they are coded against the newer one.

Maybe this is something we can handle in aegir.

@achingbrain
Copy link
Member

@paralin the stream muxer compliance tests have been released, please can you update this PR to pull in the latest version?

@achingbrain achingbrain changed the title fix: upgrade to interface-stream-muxer 2.0.0 fix!: upgrade to interface-stream-muxer 2.0.0 Jun 28, 2022
@achingbrain achingbrain merged commit f11f2ce into libp2p:master Jun 28, 2022
github-actions bot pushed a commit that referenced this pull request Jun 28, 2022
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
0dbb3db 
## [4.0.0](v3.0.0...v4.0.0) (2022-06-28)

### ⚠ BREAKING CHANGES

* upgrade to interface-stream-muxer 2.0.0 (#186)

### Bug Fixes

* upgrade to interface-stream-muxer 2.0.0 ([#186](#186)) ([f11f2ce](f11f2ce)), closes [#185](#185)
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with interface-stream-muxer 2.0.0: needs closer
3 participants
@paralin @wemeetagain @achingbrain