This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
deps(dev): Upgrade aegir to 38.1.7 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is there a direct dep on typescript here? Is it just an old mistake? |
|
Not a direct dep, but currently master is failing because of an indirect dep on |
achingbrain
changed the title
|
Hmm, still not sure why there's a typescript dep here at all, there's nothing special or unique about the repo setup, I think it's just been hanging around for ages and was never removed. |
|
I think I misunderstood the original comment 😅 thanks! |
achingbrain
approved these changes
Mar 21, 2023
achingbrain
reviewed
Mar 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
## [7.1.2](v7.1.1...v7.1.2) (2023-03-21) ### Trivial Changes * replace err-code with CodeError ([#242](#242)) ([8d58a3b](8d58a3b)), closes [js-libp2p#1269](libp2p/js-libp2p#1269) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([54de88d](54de88d)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([df03e8d](df03e8d)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([9c3f235](9c3f235)) ### Dependencies * **dev:** bump typescript from 4.9.5 to 5.0.2 ([#256](#256)) ([a3590af](a3590af)) * **dev:** Upgrade aegir to 38.1.7 ([#257](#257)) ([e0bf45a](e0bf45a))
|
🎉 This PR is included in version 7.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also reverting typescript to
4.9.5because a3590af upgraded it, but aegir depends on eslint-plugin-etc ( as well as eslint-config-ipfs which also depends oneslint-plugin-etc) which is incompatible with TS5 atm cartant/eslint-plugin-etc#53.