chore: peer-discovery not using peer-info #5
Conversation
vasco-santos
force-pushed
the
chore/peer-discovery-not-using-peer-info
branch
from
f48e849 to
26d4cb4
Compare
BREAKING CHANGE: peer event emits an object with id and multiaddr instead of a peer-info
vasco-santos
force-pushed
the
chore/peer-discovery-not-using-peer-info
branch
from
26d4cb4 to
e89629e
Compare
| @@ -54,6 +56,7 @@ class PubsubPeerDiscovery extends Emittery { | |||
| } | |||
|
|
|||
| this.removeListener = this.off.bind(this) | |||
| this.removeAllListeners = this.clearListeners.bind(this) | |||
There was a problem hiding this comment.
What's using this? If this is being used we likely need to get more explicit about what event api peer-discovery modules should be exposing.
There was a problem hiding this comment.
It is being used fot the tests: https://github.com/libp2p/js-libp2p-interfaces/blob/v0.3.0/src/peer-discovery/tests/index.js#L25
I agree that we should be explicit about it.
src/index.js
Outdated
| @@ -31,17 +30,20 @@ class PubsubPeerDiscovery extends Emittery { | |||
| * @constructor | |||
| * @param {Libp2p} param0.libp2p Our libp2p node | |||
| * @param {number} [param0.interval = 10000] How often (ms) we should broadcast our infos | |||
| * @param {Array<Multiaddr>} param0.multiaddrs Multiaddrs used by the node to listen. | |||
There was a problem hiding this comment.
How are these intended to get passed in? I would recommend not doing this and instead we should just leverage the announce addrs. I don't believe that's done yet, so in the interim we may want to just do this.libp2p.transportManager.getAddrs(). This removes any need to add special options for the addresses, which is not friendly for new users.
There was a problem hiding this comment.
Ok, we can use the transportManager.getAddrs() and I will open an issue to use the addressManager in the future
There was a problem hiding this comment.
Removed the param, using the transport manager for now and issue created #6
|
Released a major since this was already on 1.x dist-tags:
beta: 2.0.0 latest: 1.0.0 |
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR changes thepeer-discoveryinterface to emit an object containing anidproperty and amultiaddrsproperty.This PR also adds the new
peer-discoveryinterface testsBREAKING CHANGE: peer event emits an object with id and multiaddr instead of a peer-info
Needs: