fix: use unidirectional streams

libp2p · Jun 3, 2020 · fa0f839 · fa0f839
1 parent 508a632
commit fa0f839
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -178,7 +178,6 @@ class PubsubBaseProtocol extends EventEmitter {
       protocols: [protocol]
     }))
 
-    peer.attachConnection(stream)
     this._processMessages(idB58Str, stream, peer)
   }
 
@@ -200,7 +199,6 @@ class PubsubBaseProtocol extends EventEmitter {
     try {
       const { stream } = await conn.newStream(this.multicodecs)
       peer.attachConnection(stream)
-      this._processMessages(idB58Str, stream, peer)
     } catch (err) {
       this.log.err(err)
     }

diff --git a/src/peer.js b/src/peer.js
@@ -87,6 +87,8 @@ class Peer extends EventEmitter {
     this.conn = conn
     this.stream = pushable({
       onEnd: () => {
+        // close readable side of the stream
+        this.conn.source.end && this.conn.source.end()
         this.conn = null
         this.stream = null
         this.emit('close')