Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix: remove node globals #42

Merged
merged 1 commit into from
Apr 23, 2020
Merged

fix: remove node globals #42

merged 1 commit into from
Apr 23, 2020

Conversation

hugomrdias
Copy link
Member

Related to ipfs/js-ipfs#2924

@hugomrdias hugomrdias mentioned this pull request Apr 23, 2020
Closed
56 tasks
vasco-santos
vasco-santos approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos
Copy link
Member

FYI we just release yesterday libp2p-pubsub@0.5.0 as a beta release. This will only be available to use on libp2p@0.28. As a result, I am merging this here, and then cherry pick this commit to also release a patch of 0.4.x

@vasco-santos vasco-santos merged commit 636041b into master Apr 23, 2020
@vasco-santos vasco-santos deleted the fix/remove-node-globals branch April 23, 2020 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @vasco-santos