This repository has been archived by the owner on May 16, 2024. It is now read-only.
fix: emit copy of metrics #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent observers changing internal state, emit a copy of the metrics.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
## 1.0.0 (2023-09-20) ### Features * initial import ([dda8a8a](dda8a8a)) ### Bug Fixes * emit copy of metrics ([#1](#1)) ([ede5c64](ede5c64)) ### Trivial Changes * add release script ([107ee5e](107ee5e)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([8175453](8175453)) * Update .github/workflows/stale.yml [skip ci] ([0705c63](0705c63)) * update project config ([6510681](6510681))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
SgtPooki
reviewed
Sep 20, 2023
| @@ -158,7 +158,7 @@ class SimpleMetrics implements Metrics, Startable { | |||
| } | |||
| } | |||
|
|
|||
| this.onMetrics(output) | |||
| this.onMetrics(JSON.parse(JSON.stringify(output))) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
No reason - PR please!
There was a problem hiding this comment.
That said, JSON stringify/parse seems to be faster? - benchmark
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent observers changing internal state, emit a copy of the metrics.