fix: prevent undefined error during a mutual hangup

libp2p · May 29, 2018 · a7e2ae2 · a7e2ae2
1 parent 4b60484
commit a7e2ae2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/dial.js b/src/dial.js
@@ -212,8 +212,9 @@ class Dialer {
         }
 
         const muxedConn = this.switch.muxers[key].dialer(conn)
-        this.switch.muxedConns[b58Id] = {}
-        this.switch.muxedConns[b58Id].muxer = muxedConn
+        this.switch.muxedConns[b58Id] = {
+          muxer: muxedConn
+        }
 
         muxedConn.once('close', () => {
           delete this.switch.muxedConns[b58Id]

diff --git a/src/index.js b/src/index.js
@@ -110,6 +110,11 @@ class Switch extends EE {
     this.stats.stop()
     series([
       (cb) => each(this.muxedConns, (conn, cb) => {
+        // If the connection was destroyed while we are hanging up, continue
+        if (conn === undefined) {
+          return cb()
+        }
+
         conn.muxer.end((err) => {
           // If OK things are fine, and someone just shut down
           if (err && err.message !== 'Fatal error: OK') {