Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Use retimer to avoid creating so many timers #289

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Use retimer to avoid creating so many timers #289

merged 2 commits into from
Dec 13, 2018

Conversation

mcollina
Copy link
Contributor

This PR does three things

  • Use retimer to reduce the number of timers that needs to be created.
  • Remove an unneeded setImmediate
  • Fixes linting

@ghost ghost assigned mcollina Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
jacobheun
jacobheun approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'll fix the commitlint on squash

@jacobheun jacobheun merged commit f43084b into master Dec 13, 2018
@ghost ghost removed the in progress label Dec 13, 2018
@jacobheun jacobheun deleted the use-retimer branch December 13, 2018 19:07
@mcollina
Copy link
Contributor Author

Wow this was quick!

@mcollina mcollina mentioned this pull request Aug 22, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

@daviddias daviddias Awaiting requested review from daviddias

Assignees

@mcollina mcollina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @jacobheun