Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

feat: update identify to include supported protocols #311

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Mar 19, 2019

This leverages an updated version of libp2p-identify to store and retrieve the protocols for peers on connection.

Replaces #307, Resolves #304

Depends on libp2p/js-libp2p-identify#51
Requires #310 as it's rebased from it to avoid conflicts

@ghost ghost assigned jacobheun Mar 19, 2019
@ghost ghost added the in progress label Mar 19, 2019
@jacobheun jacobheun marked this pull request as ready for review March 19, 2019 18:07
@jacobheun jacobheun requested a review from vasco-santos March 19, 2019 18:07
@jacobheun jacobheun changed the title feat: update identify to feat: update identify to include supported protocols Mar 19, 2019
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do not forget to update the package.json

@jacobheun jacobheun changed the base branch from feat/dial-queue to master March 20, 2019 17:52
@jacobheun jacobheun merged commit 46e2509 into master Mar 21, 2019
@jacobheun jacobheun deleted the feat/identify branch March 21, 2019 08:52
@ghost ghost removed the in progress label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants