Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Add Typescript support #145

Merged
merged 8 commits into from
Jun 10, 2021
Merged

Add Typescript support #145

merged 8 commits into from
Jun 10, 2021

Conversation

nazarhussain
Copy link
Contributor

With reference to the issue libp2p/js-libp2p#659 this PR will add typescript support to libp2p-tcp.

vasco-santos
vasco-santos suggested changes May 31, 2021
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @nazarhussain

I did a first pass review

package.json Outdated Show resolved Hide resolved
types/abortable-iterator/index.d.ts Outdated Show resolved Hide resolved
@nazarhussain nazarhussain requested a review from vasco-santos May 31, 2021 20:50
vasco-santos
vasco-santos suggested changes Jun 1, 2021
View reviewed changes
src/index.js Show resolved Hide resolved
src/listener.js Show resolved Hide resolved
src/typedefs.js Outdated Show resolved Hide resolved
@nazarhussain nazarhussain requested a review from vasco-santos June 3, 2021 21:24
@nazarhussain
Copy link
Contributor Author

@vasco-santos Hope changes looks fine now. I also wanna know why are not using the typescript itself? and using JSDoc to TS approach?

@lidel lidel requested a review from yusefnapora June 7, 2021 14:35
@nazarhussain
Copy link
Contributor Author

If changes in this PR looks good then I will create few more for other packages in libp2p which yet not supporting TS. Waiting for this PR to get approved.

yusefnapora
yusefnapora approved these changes Jun 9, 2021
View reviewed changes
Copy link

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really solid to me, and as far as I can tell all of @vasco-santos's prior feedback has been addressed. Thanks @nazarhussain 😄

@vasco-santos vasco-santos mentioned this pull request Jun 10, 2021
Closed
@vasco-santos vasco-santos merged commit 3249e02 into libp2p:master Jun 10, 2021
@vasco-santos
Copy link
Member

Thanks @nazarhussain and @yusefnapora ❤️

@nazarhussain if you would like to add support in other repos, it will be super helpful. Please let us know in libp2p/js-libp2p#659 when you start working on any repo to avoid work collisions

@vasco-santos
Copy link
Member

Release 0.16.0 with this

@nazarhussain nazarhussain deleted the nh-ts-support branch June 10, 2021 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

Assignees
No one assigned
Labels
None yet
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazarhussain @vasco-santos @yusefnapora