This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
comply with the latest interface-transport and interface-connection spec #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
follow-spec
branch
3 times, most recently
from
62161db to
1ec7a4a
Compare
|
This is ready. I feel really happy with the new state of Connection and Transport, the interfaces are simply nice, wrapping conns is nice, everything works, it will unblock and make things so much easier to fix the identify madness. Would appreciate CR @dignifiedquire @haadcode Before merging, I'll pass the //cc @whyrusleeping PS: circle-ci fails just cause of lack of IPv6 support |
|
You should either disable IPv6 test on circle, or remove circle as with it it becomes almost useless. |
|
@Kubuxu disabled circle :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.