Make libp2p-utp an happy transport and part of the libp2p blessed family #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2019
Closed
daviddias
force-pushed
the
happy-transport
branch
from
2dc5eba to
891da8d
Compare
|
@daviddias I just want to make sure you're aware that interface-transport has recently been updated to use async/await and interface-connection is currently being modified. The corresponding WIP js-libp2p-tcp PR is here: libp2p/js-libp2p-tcp#102 |
|
Thanks for letting me know, @dirkmc :) |
|
There's a few TODOs in the code i.e. IPv6 and 0.0.0.0 support. Are they blocking this from being merged? |
|
@alanshaw it is an improvement on what was there and it doesn't break anything from what existed (in fact, just makes it work). I would be fine merging this now and then finishing the rest of the TODO separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making some progress on getting libp2p to behave as libp2p needs it to.