This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
chore: peer-discovery not using peer-info #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: peer event emits with id and multiaddrs properties instead of peer-info
vasco-santos
force-pushed
the
chore/peer-discovery-not-using-peer-info
branch
from
354035c to
a281188
Compare
jacobheun
suggested changes
Apr 21, 2020
|
It is using a tag from branch with some skipped tests of the interface. Context #183 (comment) I rebased that branch with the latest stuff from |
jacobheun
approved these changes
Apr 21, 2020
|
Issue created #214 , going to merge and release with as beta for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR changes thepeer-discoveryinterface to emit an object containing anidproperty and amultiaddrsproperty.BREAKING CHANGE: peer event emits an object with id and multiaddr instead of a peer-info
Needs: