-
Notifications
You must be signed in to change notification settings - Fork 94
fix: replace node buffers with uint8arrays #244
Conversation
BREAKING CHANGES: - All deps used by this module now use Uint8Arrays in place of node Buffers
Master of this repo depends on this unmerged branch: https://github.com/libp2p/js-libp2p-interfaces/tree/chore/skip-abort-while-reading-for-webrtc I think it might need merging before the tests will pass. |
We have #214 to track the dep issue. There are a couple of tests failling with the interface and we want to tackle them when we iterate on webrtc with distributed signalling. |
I added a PR to aegir to let us just skip this via the cli so we can do it in travis instead of depending on that branch, ipfs/aegir#622. I looked into the issue with the tests but will need more time to fix the root cause. The issue with the abort error not being thrown is that SimplePeer is overriding |
I just updated the interface tag. But, I like your solution more! 👍 |
The simple-peer fork needed to switch over to Uint8Arrays, so I went ahead and just fixed the underlying destroy problem. ipfs-shipyard/simple-peer#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should all be fixed. The previously skipped tests are also fixed now.
BREAKING CHANGES:
also fixes #214