feat/bring that dns #84
Conversation
| } else { | ||
| if (ma.protos()[2].name === 'ws') { | ||
| return 'http://' + maStrSplit[3] | ||
| } else if (ma.protos()[3].name === 'wss') { |
There was a problem hiding this comment.
This seems wrong, why 2 in the ws case and 3 in the wss case?
There was a problem hiding this comment.
it is wrong indeed (I couldn't test https without the cert)
daviddias
force-pushed
the
feat/bring-that-dns
branch
from
fe1ab16 to
d47197b
Compare
| return 'https://' + maStrSplit[3] | ||
| } else { | ||
| throw new Error('invalid multiaddr' + ma.toString()) | ||
| } |
There was a problem hiding this comment.
Maybe simplify the code to avoid issues like before.
const wsToHttp = (name) => {
if (name === 'ws') {
return 'http'
}
if (name === 'wss') {
return 'https'
}
throw new Error('sad face')
}
const protocol = wsToHttp(ma.protos()[2].name)
return `${protocol}://${maStrSplit[3]}`
|
|
||
| ### Deployment | ||
|
|
||
| We have a [dokku](https://github.com/ipfs/ops-requests/issues/31) setup ready for this to be deployed, to deploy simple do (you have to have permission first): | ||
|
|
||
| ```sh | ||
| # if you already have added the remote, you don't need to do it again | ||
| > git remote add dokku dokku@cloud.ipfs.team:webrtc-star-signalling | ||
| > git remote add dokku dokku@cloud.ipfs.team:star-signall |
There was a problem hiding this comment.
Typo, should be star-signal I'm assuming
| const maLS = '/ip4/127.0.0.1/tcp/15555' | ||
| const maGen = (base, id) => multiaddr(`/libp2p-webrtc-star${base}/ws/ipfs/${id}`) | ||
|
|
||
| if (process.env.DNS) { |
There was a problem hiding this comment.
Probably should prefix this env var so it becomes WEBRTC_START_DNS instead, just to avoid any collisions.
There was a problem hiding this comment.
The currently deployed thing is called webrtc-star-signalling(.cloud.ipfs.team), is it gonna change? (No problem with that, just checking)
There was a problem hiding this comment.
@lgierth I would like it to be shorter, like star-signal. or signal., but I'm happy with any, really.
There was a problem hiding this comment.
Cool, just make a call and deploy :) and I'll take care of setting up Let's Encrypt for all cloud.ipfs.team apps.
There was a problem hiding this comment.
» ssh dokku@cloud.ipfs.team apps
=====> My Apps
star-signal
@lgierth do your magic 🎩 :D
@lgierth do your magic 🎩 :D |
@lgierth I've updated the module to support DNS and I've confirmed it works. To reproduce,
npm run test:dnsRequires:
Now all we need is that Certificate and that Reverse Proxy for WebSockets :)