Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

v0.1.0 #1

Merged
merged 2 commits into from
Sep 8, 2017
Merged

v0.1.0 #1

merged 2 commits into from
Sep 8, 2017

Conversation

daviddias
Copy link
Member

@daviddias
Copy link
Member Author

daviddias commented Sep 8, 2017

@mkg20001 would love to have your review on this PR so that you could check and see what I refactored. Overall there is a lot of work here! Thank you so much for pushing this 👏🏽👏🏽

I improved the code a bit just by following the standard style we use for our JS projects.

One thing that I caught often was callback('some error message'), errors need to be instances of Error, otherwise, things might break somewhere. The correct way of doing it is simply callback(new Error('some error message')).

One of the ways to ensure that your code is in check before committing is by using the Standard code style linter, it is "code style" but it captures some bugs such as things undefined, different name, errors not handled and so on. You can check it here https://standardjs.com/, there are multiple plugins and there should be one for the editor you use. In last resort, you can always run npm run lint before committing.

There is still more parts of the code that can be modularized and tested so that it gets easier to maintain. Nevertheless, it is super cool to see so many tests here and in the transport module 💯

@daviddias daviddias merged commit 9009dcc into master Sep 8, 2017
@daviddias daviddias deleted the feat/0.1.0 branch September 8, 2017 09:35
Copy link
Member

@mkg20001 mkg20001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
Awesome work you have done! 👍

This will install a `websockets-star` CLI tool. Now you can spawn the server with:

```bash
> websockets-star --port=9090 --host=127.0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an s? It's still named websocket-star

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a typo. I fixed it a bunch of times myself and still missed this one, my bad!

@daviddias
Copy link
Member Author

Awesome work you have done! 👍

I just moved things around, you are the one who crushed it! 👏🏽👏🏽👏🏽

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants