This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
follow new transport and connection spec #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
follow-spec
branch
2 times, most recently
from
d010c97 to
2dab331
Compare
daviddias
force-pushed
the
follow-spec
branch
4 times, most recently
from
98e1ef6 to
fc834fd
Compare
| const isNode = require('detect-node') | ||
| let SWS | ||
| if (isNode) { | ||
| SWS = require('simple-websocket-server') |
There was a problem hiding this comment.
this still requires to have a fake simple-websocket-server in the webpack config :/ not sure how to better solve it though
There was a problem hiding this comment.
We get some warning of missing deps, namely:
WARNING in ./~/ws/lib/Validation.js
Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/david/code/js-libp2p-websockets/node_modules/ws/lib'
@ ./~/ws/lib/Validation.js 10:19-44
WARNING in ./~/ws/lib/BufferUtil.js
Module not found: Error: Can't resolve 'bufferutil' in '/Users/david/code/js-libp2p-websockets/node_modules/ws/lib'
@ ./~/ws/lib/BufferUtil.js 10:19-40
But since the execution never goes there, no error is caused. Do we need to 'fix' these warnings?
There was a problem hiding this comment.
Would be better, try adding 'simple-websocket-server': '{}' to the externals list
There was a problem hiding this comment.
done. no more warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.