chore: apply suggestions from code review

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
libp2p · Apr 21, 2020 · 7aae306 · 7aae306
1 parent 21a63cb
commit 7aae306
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "it-pipe": "^1.0.1",
     "it-pushable": "^1.3.2",
     "libp2p-crypto": "~0.17.0",
-    "libp2p-interfaces": "libp2p/js-interfaces#v0.3.x",
+    "libp2p-interfaces": "^0.3.0",
     "peer-id": "~0.13.3",
     "protons": "^1.0.1"
   },

diff --git a/src/index.js b/src/index.js
@@ -79,7 +79,6 @@ class PubsubBaseProtocol extends EventEmitter {
     this.log.err = debug(`${debugName}:error`)
 
     this.multicodecs = utils.ensureArray(multicodecs)
-    this.signMessages = peerId
     this.registrar = registrar
 
     this.started = false
@@ -174,7 +173,10 @@ class PubsubBaseProtocol extends EventEmitter {
     const peerId = connection.remotePeer
     const idB58Str = peerId.toB58String()
 
-    const peer = this._addPeer(new Peer(peerId, [protocol]))
+    const peer = this._addPeer(new Peer({
+      id: peerId,
+      protocols: [protocol]
+    }))
 
     peer.attachConnection(stream)
     this._processMessages(idB58Str, stream, peer)
@@ -190,7 +192,11 @@ class PubsubBaseProtocol extends EventEmitter {
     const idB58Str = peerId.toB58String()
     this.log('connected', idB58Str)
 
-    const peer = this._addPeer(new Peer(peerId, this.multicodecs))
+    const peer = this._addPeer(new Peer({
+      id: peerId,
+      protocols: this.multicodecs
+    }))
+
     try {
       const { stream } = await conn.newStream(this.multicodecs)
       peer.attachConnection(stream)

diff --git a/src/peer.js b/src/peer.js
@@ -16,7 +16,7 @@ class Peer extends EventEmitter {
    * @param {PeerId} id
    * @param {Array<string>} protocols
    */
-  constructor (id, protocols) {
+  constructor ({ id, protocols }) {
     super()
 
     /**

diff --git a/test/pubsub.spec.js b/test/pubsub.spec.js
@@ -301,7 +301,7 @@ describe('pubsub base protocol', () => {
       expect(peersSubscribed).to.be.empty()
 
       // Set mock peer subscribed
-      const peer = new Peer(peerId)
+      const peer = new Peer({ id: peerId })
       const id = peer.id.toB58String()
 
       peer.topics.add(topic)