fix: allow creating counter groups (#2550)

Fixes a small bug in the creation of in-memory metrics.

packages/metrics-simple/src/index.ts

@@ -245,7 +245,7 @@ class SimpleMetrics implements Metrics, Startable {
       return
     }
 
-    const metric = new DefaultMetric()
+    const metric = new DefaultGroupMetric()
     this.metrics.set(name, metric)
 
     return metric
@@ -264,7 +264,7 @@ class SimpleMetrics implements Metrics, Startable {
       return
     }
 
-    const metric = new DefaultGroupMetric()
+    const metric = new DefaultMetric()
     this.metrics.set(name, metric)
 
     return metric

packages/metrics-simple/test/index.spec.ts

@@ -55,4 +55,92 @@ describe('simple-metrics', () => {
 
     expect(list).to.not.have.nested.property('[1].foo.baz')
   })
+
+  it('should create a metric', async () => {
+    const deferred = pDefer<Record<string, any>>()
+
+    s = simpleMetrics({
+      onMetrics: (metrics) => {
+        deferred.resolve(metrics)
+      },
+      intervalMs: 10
+    })({})
+
+    await start(s)
+
+    const m = s.registerMetric('test_metric')
+    m.update(10)
+
+    const metrics = await deferred.promise
+    expect(metrics).to.have.property('test_metric', 10)
+  })
+
+  it('should create a counter metric', async () => {
+    const deferred = pDefer<Record<string, any>>()
+
+    s = simpleMetrics({
+      onMetrics: (metrics) => {
+        deferred.resolve(metrics)
+      },
+      intervalMs: 10
+    })({})
+
+    await start(s)
+
+    const m = s.registerCounter('test_metric')
+    m.increment()
+
+    const metrics = await deferred.promise
+    expect(metrics).to.have.property('test_metric', 1)
+  })
+
+  it('should create a metric group', async () => {
+    const deferred = pDefer<Record<string, any>>()
+
+    s = simpleMetrics({
+      onMetrics: (metrics) => {
+        deferred.resolve(metrics)
+      },
+      intervalMs: 10
+    })({})
+
+    await start(s)
+
+    const m = s.registerMetricGroup('test_metric')
+    m.update({
+      foo: 10,
+      bar: 20
+    })
+
+    const metrics = await deferred.promise
+    expect(metrics).to.have.deep.property('test_metric', {
+      foo: 10,
+      bar: 20
+    })
+  })
+
+  it('should create a metric counter group', async () => {
+    const deferred = pDefer<Record<string, any>>()
+
+    s = simpleMetrics({
+      onMetrics: (metrics) => {
+        deferred.resolve(metrics)
+      },
+      intervalMs: 10
+    })({})
+
+    await start(s)
+
+    const m = s.registerCounterGroup('test_metric')
+    m.increment({
+      foo: 10,
+      bar: 20
+    })
+
+    const metrics = await deferred.promise
+    expect(metrics).to.have.deep.property('test_metric', {
+      foo: 10,
+      bar: 20
+    })
+  })
 })