fix: update max message size SDP attribute (#1909)

Updates max message size to comply with spec. Closes #1908
libp2p · Jul 31, 2023 · e6a41f7 · e6a41f7
1 parent 1f7e18b
commit e6a41f7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/transport-webrtc/src/private-to-public/sdp.ts b/packages/transport-webrtc/src/private-to-public/sdp.ts
@@ -133,7 +133,7 @@ a=ice-ufrag:${ufrag}
 a=ice-pwd:${ufrag}
 a=fingerprint:${CERTFP}
 a=sctp-port:5000
-a=max-message-size:100000
+a=max-message-size:16384
 a=candidate:1467250027 1 UDP 1467250027 ${host} ${port} typ host\r\n`
 }
 

diff --git a/packages/transport-webrtc/test/sdp.spec.ts b/packages/transport-webrtc/test/sdp.spec.ts
@@ -17,7 +17,7 @@ a=ice-ufrag:MyUserFragment
 a=ice-pwd:MyUserFragment
 a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1
 a=sctp-port:5000
-a=max-message-size:100000
+a=max-message-size:16384
 a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host`
 
 describe('SDP', () => {
@@ -73,7 +73,7 @@ a=ice-ufrag:someotheruserfragmentstring
 a=ice-pwd:someotheruserfragmentstring
 a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1
 a=sctp-port:5000
-a=max-message-size:100000
+a=max-message-size:16384
 a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host`
 
     expect(result.sdp).to.equal(expected)