Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time to expose PubSub as a libp2p primitive on the libp2p Class #140

Closed
daviddias opened this issue Dec 15, 2017 · 3 comments
Closed

Time to expose PubSub as a libp2p primitive on the libp2p Class #140

daviddias opened this issue Dec 15, 2017 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up

Comments

@daviddias
Copy link
Member

I believe it is time to expose PubSub as a core libp2p primitive as well instead of it being an external module that mounts on top of libp2p. Thoughts?
@richardschneider
Copy link
Contributor

@daviddias
Copy link
Member Author

Does this imply dropping the experimental status of pubsub?

It doesn't. PubSub is experimental on IPFS and will continue to be. In libp2p everything is plug&play/on&off, users could always use it but had to do more work.

@daviddias daviddias changed the title Time to expose PubSub as a libp2p primitive Time to expose PubSub as a libp2p primitive on the libp2p Class Dec 15, 2017
@daviddias daviddias added the status/ready Ready to be worked label Feb 5, 2018
@daviddias daviddias mentioned this issue Feb 5, 2018
Closed
13 tasks
@daviddias daviddias added exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up labels Feb 5, 2018
@daviddias
Copy link
Member Author

Done on version 0.18.0 :)

@ghost ghost removed the status/ready Ready to be worked label Feb 20, 2018
achingbrain added a commit that referenced this issue Jun 27, 2023
@achingbrain
fix: update interfaces (#140)
c6f622c 
Updates to latest code from libp2p/js-libp2p-interfaces#180
achingbrain pushed a commit that referenced this issue Jun 27, 2023
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
12a4150 
### [1.0.1](libp2p/js-libp2p-floodsub@v1.0.0...v1.0.1) (2022-03-16)

### Bug Fixes

* update interfaces ([#140](libp2p/js-libp2p-floodsub#140)) ([c6f622c](libp2p/js-libp2p-floodsub@c6f622c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardschneider @daviddias