Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch dialling #1616

Closed
achingbrain opened this issue Mar 8, 2023 · 0 comments · Fixed by #1623
Closed

Batch dialling #1616

achingbrain opened this issue Mar 8, 2023 · 0 comments · Fixed by #1623
Assignees
@maschad
Labels
effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

The libp2p.dial method should support dialling multiple multiaddrs - it currently supports dialing a peer id (in which case multiaddrs are retrieved from the peer store) or a single multiaddr.

Since only a single connection is returned from a dial, the multiaddrs being dialled should be checked to ensure they either all contain the same peer id or that none of them contain a peer id.

If they all have the same peer id we are guaranteed to return a connection to the expected remote peer, if none of them contain a peer id then the user did not expect a connection to a specific peer so we are ok to return a connection to whatever remote peer we managed to connect to first.
@achingbrain achingbrain added need/triage Needs initial labeling and prioritization kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue effort/days Estimated to take multiple days, but less than a week and removed need/triage Needs initial labeling and prioritization labels Mar 8, 2023
@maschad maschad self-assigned this Mar 9, 2023
@maschad maschad mentioned this issue Mar 10, 2023
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue Mar 11, 2023
@maschad
feat: support batch dialling (libp2p#1616)
9cf6606
@maschad maschad mentioned this issue Mar 11, 2023
Merged
@p-shahi p-shahi removed the help wanted Seeking public contribution on this issue label Mar 16, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Mar 27, 2023
@maschad
feat: support batch dialling for multiple multiaddrs (libp2p#1616)
5fcf8dc
maschad added a commit to maschad/js-libp2p that referenced this issue Mar 27, 2023
@maschad
fix: updated error messages for invalid multiaddr batches (libp2p#1616)
7599911
maschad added a commit to maschad/js-libp2p that referenced this issue Mar 29, 2023
@maschad
fix: abort dial targets and creation of other connections to avoid me…
faa5314 
…mory leaks (libp2p#1616)
achingbrain added a commit that referenced this issue Mar 30, 2023
@maschad @achingbrain
feat: support batch dialling (#1623)
290e610 
Allows users to dial multiple multiaddrs at the same time, as long as they either all have the same peer id or none of them have a peer id.

Closes #1616

---------

Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain pushed a commit to libp2p/js-libp2p-interfaces that referenced this issue Apr 5, 2023
@maschad
feat: support batch dialling (#351)
e46b72b 
See libp2p/js-libp2p#1616 for more details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
effort/days Estimated to take multiple days, but less than a week kind/enhancement A net-new feature or improvement to an existing feature
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support batch dialling maschad/js-libp2p
3 participants
@achingbrain @maschad @p-shahi