Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(examples) Readme needs updating to v45 api #1810

Closed
DougAnderson444 opened this issue Jun 14, 2023 · 1 comment · Fixed by #1821
Closed

(examples) Readme needs updating to v45 api #1810

DougAnderson444 opened this issue Jun 14, 2023 · 1 comment · Fixed by #1821

Comments

@DougAnderson444
Copy link
Contributor

js-libp2p/examples/pubsub/README.md

Line 66 in de61ddb

node1.pubsub.addEventListener("message", (evt) => {

@maschad
Copy link
Member

maschad commented Jun 14, 2023 •
edited
Loading

Thanks for raising this @DougAnderson444 , these types of doc issues should be solved once we have #1505 merged and #1777 resolved.

In the interim would you be able to create a PR to update this in the README?

@DougAnderson444 DougAnderson444 mentioned this issue Jun 15, 2023
Merged
achingbrain pushed a commit that referenced this issue Jun 19, 2023
@DougAnderson444
docs: Update readme docs to reflect v0.45.x api (#1821)
ab0e398 
Fixes #1810
achingbrain pushed a commit that referenced this issue Jun 19, 2023
@DougAnderson444 @achingbrain
docs: Update readme docs to reflect v0.45.x api (#1821)
70060e8 
Fixes #1810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Update readme docs to reflect v0.45.x api
2 participants
@DougAnderson444 @maschad