Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prioritize peers based on previous dial succession / failure #1953

Closed
maschad opened this issue Aug 10, 2023 · 1 comment
Closed

feat: Prioritize peers based on previous dial succession / failure #1953

maschad opened this issue Aug 10, 2023 · 1 comment
Labels
kind/discussion Topical discussion; usually not changes to codebase kind/enhancement A net-new feature or improvement to an existing feature

Comments

@maschad
Copy link
Member

maschad commented Aug 10, 2023

Following from the conversation here,

If a peer recently failed to establish a connection, there might be underlying issues causing the failure that haven't been resolved yet (may take longer than 10 minutes), and so it's far less likely that a successful connection would result from dialling that peer, as opposed to a peer which was recently successfully dialled but for whatever a reason that connection was closed.

Modifying the tag value is not ideal. The problem is the connection manager doesn't know what it means to penalize a peer, because it doesn't know what the value of a tag added by one component means compared to a tag added by another so it cannot alter the tag values without possibly compromising the functioning of the components doing the tagging.

So if we've successfully dialled the peer recently, but we are no longer connected to them, we should prioritize those peers and conversely if we have dialled a peer but failed recently, those should be de-prioritized.

cc @achingbrain @wemeetagain @p-shahi

@maschad maschad added kind/discussion Topical discussion; usually not changes to codebase need/triage Needs initial labeling and prioritization labels Aug 10, 2023
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Aug 10, 2023
@maschad maschad added the kind/enhancement A net-new feature or improvement to an existing feature label Aug 10, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Sep 8, 2023
@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🏃‍♀️In Progress in js-libp2p Sep 12, 2023
@maschad maschad removed the need/triage Needs initial labeling and prioritization label Sep 12, 2023
@maschad
Copy link
Member Author

maschad commented Oct 2, 2023

Following the conversation on #2010 it is more useful to track success on a per address basis

@maschad maschad closed this as completed Oct 2, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️In Progress to 🎉Done in js-libp2p Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase kind/enhancement A net-new feature or improvement to an existing feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant