-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit Relay test is failing. #198
Comments
@diasdavid I'll take a look at this, I think it's just an issue with resiliency when a peer hangs up while we're also shutting down. If a peer hangs up at the same time we're shutting down (such as with test cases), it's possible we could remove the muxed connection on the hang up, as we're iterating on them to shut each of them down, making the connection undefined. I'll make sure this is the case and improve the resiliency to prevent this error. |
My assumption was correct, I have the update ready here libp2p/js-libp2p-switch#260. The PR also links to the passing CI tests for libp2p via the chore/update-switch branch. |
@diasdavid this is fixed in the latest release of switch, 0.40.3. There's another issue with the tests failing. I'll see if I can figure out what's going on there.
|
js-libp2p-webrtc-star v0.15.2 is breaking the tests, looking into it. |
Thank you @jacobheun :) |
The underlying issue appears to be with multistream-select and block-streams, which were added via libp2p/js-libp2p-webrtc-star#145, they are not playing well together. I am looking into why that's the case. I have tested this against @diasdavid I think we might want to rollback the update to libp2p-webrtc-star until this is resolved as the multistream connections won't work. I know @ya7ya is also looking into updates for block streams to fix ipfs/js-ipfs#1379, so it might be good to roll those together. If I can get the multistream-select/block-stream fix done, it should make it so we can use pull-block (I am adding tests to multistream-select using pull-block). additional infoI am seeing a clear, consistent, order of operations difference in the calls between block and non block usage. without block streams (working)
with block streams (hanging)
|
@jacobheun thank you so much for the debugging. I've added you and @pgte to have publish access of libp2p-webrtc-star so that you can unpublish the right version (https://www.npmjs.com/package/libp2p-webrtc-star/access) I'm afraid that with limited time and massive context switch that I might do a poor job of reverting those changes. |
libp2p-webrtc-star 0.15.1 has been marked as latest and the 0.15.2 changes have been rolled back into master. This issue will be resolved with the release of #203 |
## [5.0.1](libp2p/js-libp2p-websockets@v5.0.0...v5.0.1) (2022-12-08) ### Bug Fixes * cannot catch EADDRINUSE ([libp2p#198](libp2p/js-libp2p-websockets#198)) ([c7312db](libp2p/js-libp2p-websockets@c7312db)), closes [libp2p#184](libp2p/js-libp2p-websockets#184) ### Dependencies * **dev:** bump @libp2p/interface-mocks from 7.1.0 to 8.0.2 ([libp2p#199](libp2p/js-libp2p-websockets#199)) ([daff533](libp2p/js-libp2p-websockets@daff533)), closes [libp2p#318](https://github.com/libp2p/js-libp2p-websockets/issues/318) [libp2p#315](https://github.com/libp2p/js-libp2p-websockets/issues/315) [libp2p#313](https://github.com/libp2p/js-libp2p-websockets/issues/313) [libp2p#312](https://github.com/libp2p/js-libp2p-websockets/issues/312) * **dev:** bump it-all from 1.0.6 to 2.0.0 ([libp2p#193](libp2p/js-libp2p-websockets#193)) ([6213f8f](libp2p/js-libp2p-websockets@6213f8f)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24) * **dev:** bump it-drain from 1.0.5 to 2.0.0 ([libp2p#191](libp2p/js-libp2p-websockets#191)) ([e549691](libp2p/js-libp2p-websockets@e549691)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24) * **dev:** bump it-take from 1.0.2 to 2.0.0 ([libp2p#192](libp2p/js-libp2p-websockets#192)) ([4c037fc](libp2p/js-libp2p-websockets@4c037fc)), closes [libp2p#28](libp2p/js-libp2p-websockets#28)
@jacobheun could this have been introduced with the refactor? It seems that the muxer on the connection is not being correctly set up when a Relay connection happens.
//cc @dryajov
The text was updated successfully, but these errors were encountered: