Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable relay by default (not hop) #253

Closed
jacobheun opened this issue Sep 28, 2018 · 3 comments
Closed

Enable relay by default (not hop) #253

jacobheun opened this issue Sep 28, 2018 · 3 comments
Assignees
@jacobheun
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature

Comments

@jacobheun
Copy link
Contributor

Replicating go-libp2p#440 here as I think we should do it.

Enabling circuit relay by default would be a great, quick win for improved connectivity for libp2p nodes. Since interop was resolved in August, ipfs/interop#27, I think it's reasonable for us to move forward with this change.

This should just involve updating the default config value, readme and tests.

We should leave hop off by default as this could negatively impact performance for nodes and should be opt-in.

I also noticed that the IPFS default libp2p bundles aren't using relay by default and they probably should.
@jacobheun jacobheun added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up labels Sep 28, 2018
@jacobheun
Copy link
Contributor Author

@vasco-santos @diasdavid does this seem reasonable to you?

@vasco-santos
Copy link
Member

I believe that it would be an improvement for our users. So +1 on that

Finally, I completely agree that IPFS should also be using it by default

@jacobheun jacobheun mentioned this issue Sep 28, 2018
Merged
@ghost ghost assigned jacobheun Sep 28, 2018
@ghost ghost added the status/in-progress In progress label Sep 28, 2018
@jacobheun
Copy link
Contributor Author

I opened up #254 to add this. I think this would be good to add in the 0.24 release (#249).

@ghost ghost removed the status/in-progress In progress label Oct 19, 2018
@snyk-bot snyk-bot mentioned this issue Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this issue Mar 21, 2022
Open
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@web3-bot
update .github/workflows/js-test-and-release.yml (libp2p#253)
b47181b 
Co-authored-by: web3-bot <web3-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobheun jacobheun

Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @vasco-santos